Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Adding lam to the regularizer class #574

Closed
pkassraie opened this issue Aug 23, 2024 · 0 comments · Fixed by #575
Closed

Feature request: Adding lam to the regularizer class #574

pkassraie opened this issue Aug 23, 2024 · 0 comments · Fixed by #575
Assignees
Labels
enhancement New feature or request

Comments

@pkassraie
Copy link
Collaborator

https://github.com/ott-jax/ott/blob/ea7d5b9c162146fa8e716f24fad28b89b34712d8/src/ott/geometry/regularizers.py#L35C1-L35C33

Since all regularizer functions accessible to the user have a property $\lambda$ which controls the regularization strength, would it not make sense to add it to the abstract class? Sometimes in the code it make sense to do cost_fn.regularizer.lam but this gives a warning in the interpreter, as it thinks not all regularizers have a property lam.

@pkassraie pkassraie assigned pkassraie and michalk8 and unassigned pkassraie Aug 23, 2024
@pkassraie pkassraie added the enhancement New feature or request label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants