Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff View component causes crash in Safari #129

Closed
rbreeze opened this issue Jul 12, 2021 · 2 comments
Closed

Diff View component causes crash in Safari #129

rbreeze opened this issue Jul 12, 2021 · 2 comments
Labels

Comments

@rbreeze
Copy link

rbreeze commented Jul 12, 2021

After upgrading react-diff-view from v2.1.4 to v2.4.7, our application crashes in Safari v14.1.1 with error:

SyntaxError: Invalid regular expression: invalid group specifier name

This is due to a bug in normalize-url: sindresorhus/normalize-url#105

@otakustay
Copy link
Owner

How do you use react-diff-view? I tried to figure out why normalize-url is introduced:

yarn why v1.22.10
[1/4] 🤔  Why do we have the module "normalize-url"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "cssnano#cssnano-preset-default#postcss-normalize-url" depends on it
   - Hoisted from "cssnano#cssnano-preset-default#postcss-normalize-url#normalize-url"
info Disk size without dependencies: "20KB"
info Disk size with unique dependencies: "20KB"
info Disk size with transitive dependencies: "20KB"
info Number of shared dependencies: 0
✨  Done in 0.34s.

Seems this is only a dev dependency and will not go into the npm bundle. I also tried to search "normalize" and "url" from es/index.js and didn't find any normalize-url related code

For react-diff-view itself, it doen't specify any dependencies, all deps are dev deps and should be installed when you introduce this library

@stale
Copy link

stale bot commented Jul 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 27, 2021
@stale stale bot closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants