sysroot: Add ostree_sysroot_write_deployments_with_options() #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
☔ The latest upstream changes (presumably 5d413df) made this pull request unmergeable. Please resolve the merge conflicts. |
cgwalters
force-pushed
the
write-deployments-opts
branch
from
fb2f00b to
b000868
Compare
|
☔ The latest upstream changes (presumably e665e51) made this pull request unmergeable. Please resolve the merge conflicts. |
cgwalters
force-pushed
the
write-deployments-opts
branch
from
b000868 to
cc990d6
Compare
|
🛫 Rebased 🛬 |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 22, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
|
☔ The latest upstream changes (presumably 7b2370d) made this pull request unmergeable. Please resolve the merge conflicts. |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 22, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
More sophisticated users of libostree like rpm-ostree need control over things like the system repository. Previously we introduced a "no cleanup" flag to `ostree_sysroot_simple_write_deployment()`, but that's a high level API that does filtering on its own. Since rpm-ostree needs more control, let's expose the bare essentials of the "sysroot commit" operation with an extensible options structure, where one of the options is whether or not to do post-transaction repository operations.
cgwalters
force-pushed
the
write-deployments-opts
branch
from
cc990d6 to
92be53b
Compare
|
🛫 Rebased 🛬 |
jlebon
reviewed
Mar 23, 2017
| @@ -1686,25 +1686,41 @@ is_ro_mount (const char *path) | |||
| * @cancellable: Cancellable | |||
| * @error: Error | |||
| * | |||
| * Assuming @new_deployments have already been deployed in place on | |||
| * disk, atomically update bootloader configuration. | |||
| * Older verison of ostree_sysroot_write_deployments() - will perform | |||
There was a problem hiding this comment.
s/ostree_sysroot_write_deployments/ostree_sysroot_write_deployments_with_options/ ?
| * | ||
| * Assuming @new_deployments have already been deployed in place on disk via | ||
| * ostree_sysroot_deploy_tree(), atomically update bootloader configuration. By | ||
| * default, no-post-transaction cleanup will be performed. You should invoke |
There was a problem hiding this comment.
Adding a comment here that I've addressed your comments on the code comments ⬇️
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 23, 2017
More sophisticated users of libostree like rpm-ostree need control over things like the system repository. Previously we introduced a "no cleanup" flag to `ostree_sysroot_simple_write_deployment()`, but that's a high level API that does filtering on its own. Since rpm-ostree needs more control, let's expose the bare essentials of the "sysroot commit" operation with an extensible options structure, where one of the options is whether or not to do post-transaction repository operations. Closes: #745 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-atomicjenkins |
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 23, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 24, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 27, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 27, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Mar 31, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 13, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 13, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 20, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 21, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
cgwalters
added a commit
to cgwalters/rpm-ostree
that referenced
this pull request
Apr 25, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much.
rh-atomic-bot
pushed a commit
to coreos/rpm-ostree
that referenced
this pull request
Apr 26, 2017
This is prep for livefs. We need to tweak the logic from what core libostree has in `ostree_sysroot_simple_write_deployment()`, and while we could land improved logic there, I think it makes sense to carry this here until we're confident enough in the logic to make it ABI. This does depend on a [new libostree API](ostreedev/ostree#745) that allows writing deployments without doing cleanup. The `bump_mtime()` bit is also prep for livefs, carrying in this patch to avoid splitting things too much. Closes: #709 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends: #744
More sophisticated users of libostree like rpm-ostree need control over things
like the system repository. Previously we introduced a "no cleanup" flag to
ostree_sysroot_simple_write_deployment(), but that's a high level API thatdoes filtering on its own.
Since rpm-ostree needs more control, let's expose the bare essentials of the
"sysroot commit" operation with an extensible options structure, where one of
the options is whether or not to do post-transaction repository operations.