Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More intelligent pruning of tmp/ #713

Open
cgwalters opened this issue Feb 27, 2017 · 0 comments
Open

More intelligent pruning of tmp/ #713

cgwalters opened this issue Feb 27, 2017 · 0 comments

Comments

@cgwalters
Copy link
Member

Currently we have a "delete data in repo/tmp older than a day" policy. This is suboptimal for many reasons.

A workflow we want to support is doing background pulls with explicit deployments. In the case of interrupted pulls, we don't want to GC staged objects for the "latest pending commit", even if a day elapsed between pulls. However, we do want to GC staged objects not referenced by either the "new commit" or any of our current deployments.

One way to implement this might be for ostree_repo_pull() to actually do the write objects (but not commit/update the ref) if the failure was due to HTTP (but not anything else, like ENOSPC). This would move the objects out of staging, so we wouldn't have to worry about the one-day cleanup policy.

This would still mean though that ostree admin cleanup would prune those objects...we could consider writing a special "partial" ref for pending updates? Or, maybe that's a feature, and if you don't want those objects to be pruned, don't call cleanup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant