Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installed-tests fail with 2024.3: test-admin-deploy-var.sh: line 24: OSTREE_FEATURES: unbound variable #3183

Closed
smcv opened this issue Feb 19, 2024 · 0 comments · Fixed by #3184
Closed

installed-tests fail with 2024.3: test-admin-deploy-var.sh: line 24: OSTREE_FEATURES: unbound variable #3183

smcv opened this issue Feb 19, 2024 · 0 comments · Fixed by #3184

Comments

@smcv
Copy link
Contributor

smcv commented Feb 19, 2024

While running libostree's "as-installed" tests, via ginsttest-runner and Debian's autopkgtest framework:

189s Executing: libostree/test-admin-deploy-var.sh.test
189s ++ _have_user_xattrs=
189s ++ _have_systemd_and_libmount=
189s ++ _have_strace_fault_injection=
189s ++ libtest_exit_cmds+=(libtest_cleanup_gpg)
189s ++ ED25519PUBLIC=
189s ++ ED25519SEED=
189s ++ ED25519SECRET=
189s /usr/libexec/installed-tests/libostree/test-admin-deploy-var.sh: line 24: OSTREE_FEATURES: unbound variable

Probably tests that are meant to work "as-installed" should use ostree --version | grep initial-var instead?
smcv added a commit to smcv/ostree that referenced this issue Feb 19, 2024
@smcv
test-admin-deploy-var: Don't rely on OSTREE_FEATURES
1998ebb 
This is set during build-time testing, but unset during "as-installed"
tests.

Resolves: ostreedev#3183
Signed-off-by: Simon McVittie <[email protected]>
@smcv smcv mentioned this issue Feb 19, 2024
Merged
smcv added a commit to smcv/ostree that referenced this issue Feb 19, 2024
@smcv
test-admin-deploy-var: Don't rely on OSTREE_FEATURES
24ea77e 
This is set during build-time testing, but unset during "as-installed"
tests.

Resolves: ostreedev#3183
Signed-off-by: Simon McVittie <[email protected]>
smcv added a commit to smcv/ostree that referenced this issue Feb 19, 2024
@smcv
test-admin-deploy-var: Don't rely on OSTREE_FEATURES
f6f378f 
This is set during build-time testing, but unset during "as-installed"
tests.

Resolves: ostreedev#3183
Signed-off-by: Simon McVittie <[email protected]>
smcv added a commit to smcv/ostree that referenced this issue Feb 19, 2024
@smcv
test-admin-deploy-var: Don't rely on OSTREE_FEATURES
035b2c1 
This is set during build-time testing, but unset during "as-installed"
tests.

Resolves: ostreedev#3183
Signed-off-by: Simon McVittie <[email protected]>
raspbian-autopush pushed a commit to raspbian-packages/ostree that referenced this issue Oct 1, 2024
@smcv
test-admin-deploy-var: Don't rely on OSTREE_FEATURES
50c0b2c 
This is set during build-time testing, but unset during "as-installed"
tests.

Bug: ostreedev/ostree#3183
Signed-off-by: Simon McVittie <[email protected]>
Forwarded: ostreedev/ostree#3184

Gbp-Pq: Name test-admin-deploy-var-Don-t-rely-on-OSTREE_FEATURES.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test-admin-deploy-var: Don't rely on OSTREE_FEATURES smcv/ostree
1 participant
@smcv