Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient /etc breaks finding current booted deployment #3161

Closed
alexlarsson opened this issue Feb 8, 2024 · 3 comments
Closed

Transient /etc breaks finding current booted deployment #3161

alexlarsson opened this issue Feb 8, 2024 · 3 comments
Labels
triaged This issue has been evaluated and is valid

Comments

@alexlarsson
Copy link
Member

In ostree-sysroot.c:parse_deployment we stat the current root and /etc, and compare the dev+inode with the deploy dir to find the currently booted deployment. The stat of /etc was added to handle the composefs case, as in that case the root is not bind-mounted.

However in the case of composefs+transient_etc, even the etc subdirectory isn't a bind-mount, so we fail to detect that a deployment is current. I guess we need a different approach for this case.

@cgwalters cgwalters added the triaged This issue has been evaluated and is valid label Feb 8, 2024
@alexlarsson
Copy link
Member Author

I wonder if we should just bind mount the deploy dir in /run/ostree/.private at boot and stat that.

@alexlarsson
Copy link
Member Author

Surely this affects layered root as well (root is an overlayfs dir)?

@alexlarsson
Copy link
Member Author

Fixed by #3164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged This issue has been evaluated and is valid
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants