Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy parameters in Connection.new() #76

Closed
dineshnamburi opened this issue Sep 10, 2018 · 1 comment
Closed

Add support for proxy parameters in Connection.new() #76

dineshnamburi opened this issue Sep 10, 2018 · 1 comment

Comments

@dineshnamburi
Copy link

This is an enhancement request.

net-http2 gem supports proxy parameters (proxy host, port, user, password).
So, it would be great if we can pass these parameters in Apnotic::Connection.new() which in turn creates net-http2 client with these proxy params.
It will be useful for Apnotic gem users, working behind a corporate proxy.

Thanks!

@n-miyo
Copy link
Contributor

n-miyo commented Oct 23, 2018

Hi @ostinelli, thank you for creating good gem!

Do you have a plan to create code for solving this issue? I created a small PR #78 for supporting proxy settings. Could you check it if you have time.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants