Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Windows #22

Closed
osteele opened this issue Jul 15, 2017 · 2 comments
Closed

Port to Windows #22

osteele opened this issue Jul 15, 2017 · 2 comments

Comments

@osteele
Copy link
Owner

osteele commented Jul 15, 2017

See https://ci.appveyor.com/project/osteele/liquid:

# github.com/osteele/liquid/strftime
could not determine kind of name for C.localtime_r
Command exited with code 2
@osteele
Copy link
Owner Author

osteele commented Aug 8, 2017

This package no longer depends uses the C stdlib implementation of strftime. The remaining issue is time zones:

--- FAIL: TestStrftime (0.02s)
	Error Trace:	strftime_test.go:63
	Error:      	Not equal: 
	            	expected: "EST"
	            	actual: ""
	Messages:   	Strftime "%Z"
--- FAIL: TestStrftime_zones (0.00s)
	Error Trace:	strftime_test.go:146
	Error:      	Not equal: 
	            	expected: "%z=-0500 %Z=EST"
	            	actual: "%z=+0000 %Z=EST"
	Messages:   	02 Jan 06 15:04 EST
FAIL
FAIL	github.com/osteele/liquid/strftime	0.151s

https://ci.appveyor.com/project/osteele/liquid

@osteele osteele removed their assignment Aug 8, 2017
@osteele osteele changed the title Build on Windows Port to Windows Aug 8, 2017
@osteele
Copy link
Owner Author

osteele commented Aug 11, 2017

The problematic code (and test) now live in https://github.com/osteele/tuesday.

osteele/tuesday#1 is the upstream issue.

@osteele osteele closed this as completed Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant