DVR: fix large file mp4 dvr failed. #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DVR MP4 section, stco supports 32-bit offset, co64 supports 64-bit offset. Both encoding and decoding of these two boxes are implemented in SRS. However, only stco is used when writing. When the file is too large and the offset exceeds UINT32_MAX, the MP4 offset will be incorrect, resulting in playback failure for files beyond 4GB.
|
winlinvip
reviewed
Dec 17, 2021
xiaozhihong
force-pushed
the
4.0release
branch
2 times, most recently
from
7ca416f to
b439802
Compare
xiaozhihong
force-pushed
the
4.0release
branch
from
b439802 to
ec7f071
Compare
winlinvip
approved these changes
Dec 23, 2021
winlinvip
approved these changes
Dec 23, 2021
winlinvip
added a commit
that referenced
this pull request
Dec 23, 2021
peipeiguo
pushed a commit
to peipeiguo/srs
that referenced
this pull request
Sep 7, 2022
peipeiguo
pushed a commit
to peipeiguo/srs
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.