Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Pinned-Dependencies should ignore Dockerfiles and scripts in test folders #3315

Open
pnacht opened this issue Jul 26, 2023 · 3 comments

Comments

@pnacht
Copy link
Contributor

pnacht commented Jul 26, 2023

Is your feature request related to a problem? Please describe.
Pinned-Dependencies currently complains about Dockerfiles (and other scripts, I assume?) that are clearly marked as being used for tests.

Describe the solution you'd like
Similarly to Binary-Artifacts, which excuses test binaries, Pinned-Dependencies should excuse clearly identified test dependencies.

For example, aomediacodec/libavif is currently penalized for having an unpinned Dockerfile in ./tests/docker/Dockerfile.

@github-actions
Copy link

Stale issue message - this issue will be closed in 7 days

@spencerschrock
Copy link
Member

@gabibguti this is something maintainer annotations could fix,

No action needed right now, but perhaps a low priority feature once the design lands would be declaring a test folder, instead of declaring on a per-probe/check basis.

Copy link

This issue is stale because it has been open for 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants