Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Improve --show-details for Pinned-Dependencies when a certain type of file doesn't exist #2679

Closed
pnacht opened this issue Feb 17, 2023 · 1 comment · Fixed by #3436
Labels
kind/enhancement New feature or request

Comments

@pnacht
Copy link
Contributor

pnacht commented Feb 17, 2023

Is your feature request related to a problem? Please describe.
The Pinned-Dependencies check scans three types of files: workflows, Dockerfiles and shell scripts. If a certain type of file doesn't exist, --show-details outputs the same thing as if there was such a file and it was correctly pinned.

For example, a repo with no Dockerfiles gets: Info: Dockerfile dependencies are pinned Info: no insecure (not pinned by hash) dependency downloads found in Dockerfiles.

Describe the solution you'd like
When there are no files of a certain class, --show-details should say so: Info: No Dockerfile found.

@pnacht pnacht added the kind/enhancement New feature or request label Feb 17, 2023
@github-actions
Copy link

Stale issue message - this issue will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants