Add Fermi level line and E-Ef (eV) to the band structure plot #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2022 11:05
|
@unkcpz Hi Jusong, please have a look at the code. I have no idea why the annotation is working for the DOS but not for the band structure. |
|
Sorry @dou-du, I didn't manage time to work on this. Will put it to my TODO list have a look at this. |
|
I don't have any idea at the moment how to fix this, the code is a bit messy to me and I am not very familiar with js. I'll try to refactor the code a bit and then come back to tackle the issue. |
|
Hi Jusong, The issue has been fixed and it is ready to merge. The red line to represent Fermi level is added to the bandstructure figure as shown at the top of this PR. Cheers, |
unkcpz
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: aiidalab/aiidalab-qe#322
A fermi level line is also added to the band structure plot.