Release/flow/update #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dou-du
reviewed
Nov 15, 2022
| with: | ||
| python-version: '3.10' | ||
|
|
||
| - name: Install pypa/build |
There was a problem hiding this comment.
I think installation of build package is not enough. The package needs npm, jupyter_packaging, yarn etc to build the Javascript library.
There was a problem hiding this comment.
You mean without JS packages the next step would fail? Can you add me as the owner of PyPI so I can test with a true release let's say 0.4.1a0, and if it failed, I can delete it?
There was a problem hiding this comment.
Yes, you are the owner now.
There was a problem hiding this comment.
Thanks a lot! I'll give this a test.
unkcpz
force-pushed
the
release/flow/update
branch
from
1296320 to
9258c5d
Compare
Tune for voila-test Renew release workflow
unkcpz
force-pushed
the
release/flow/update
branch
from
9258c5d to
94ad0fe
Compare
unkcpz
force-pushed
the
release/flow/update
branch
from
94ad0fe to
b75e2de
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase after #39