fix(reporter): Fix aliases for renamed reporter options #9522
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fixup for 27f0dae and 88aa4a0. In those commits the reporter options `template.id` and `template.path` were renamed to `templateIds` and `templatePaths` but the aliases for backward compatibility have been set wrongly. Signed-off-by: Martin Nonnenmacher <[email protected]>
fviernau
approved these changes
Nov 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9522 +/- ##
=========================================
Coverage 67.97% 67.97%
Complexity 1290 1290
=========================================
Files 249 249
Lines 8813 8813
Branches 916 916
=========================================
Hits 5991 5991
Misses 2433 2433
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MarcelBochtler
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for 27f0dae and 88aa4a0. In those commits the reporter options
template.idandtemplate.pathwere renamed totemplateIdsandtemplatePathsbut the aliases for backward compatibility have been set wrongly.