-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
advisor-result.yml fails yamllint #7219
Comments
The And the
where
instead. But actually, both are valid according to the YAML specs. We simply rely on Jackson's default here, which is to omit unneeded indentation to reduce file size.
Actually, I know several parties are successfully parsing ORT results files with |
@sschuberth there are two reasons of this issue:
|
IMO it's really over the top that yamllint reports these as "errors". These should be "hints" at most. On the other hand, yamllint itself says that is checks for "cosmetic problems such as lines length, trailing spaces, indentation, etc." (emphasis mine). I'm not sure how valuable it is to check YAML files that are (mostly) meant for machine processing (in this case) for cosmetic problems...
You mean the issue of addressing "errors" reported by yamllint? I'd disagree that that's a good issue to address to get started: First of all, nothing is really broken, and secondly, we have some tests in the code base that strictly check actual results to match expected results incl. exact formatting, and these would break without an update of the expected results.
That largely depends on the skills of the intern...
You can retrieve my email address easily from the Git history of this project. |
Ok. I'll file an issue in yamllint proposing to lower the severity of those 2 findings, will do more tests with yq to confirm it is a bug, in which case I'll create an issue there too. |
yamllint reports indentation and line-length errors on the generated
advisor-result.yml
file:This happens with any generated advisor-result.yml file, and seems to break tools like yq.
The text was updated successfully, but these errors were encountered: