Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X500 corrupted RGBD data #917

Closed
m3d opened this issue May 18, 2021 · 19 comments
Closed

X500 corrupted RGBD data #917

m3d opened this issue May 18, 2021 · 19 comments

Comments

@m3d
Copy link
Contributor

m3d commented May 18, 2021

Hello,
we are observing corrupted RGBD data of up/down cameras in CTU_CRAS_NORLAB_X500_SENSOR_CONFIG_1 model. They are broken even after set_rate reduction. Example of sequence of depth data in Tunnel Simple 2 looks like this:
saveX-0000
saveX-0001
saveX-0002
saveX-0003

This corresponds to saving of /ROBOTNAME/up_rgbd/optical/depth/image_raw. Thanks in advance for any hint

@peci1
Copy link
Collaborator

peci1 commented May 19, 2021

was the robot rotating in yaw?

@m3d
Copy link
Contributor Author

m3d commented May 19, 2021

was the robot rotating in yaw?

yes, but not much - should it matter?

@peci1
Copy link
Collaborator

peci1 commented May 19, 2021

Yes, it does - there is a known issue where orientation w.r.t world frame affects camera clipping: gazebosim/gz-sensors#128 .

@peci1
Copy link
Collaborator

peci1 commented May 19, 2021

A workaround is to set very high near clip distance, e.g. 0.5 m was usually enough, but the you lose depth measurements if you get closer than that...

@m3d
Copy link
Contributor Author

m3d commented May 19, 2021

Interesting, thanks for hint - I would try it tonight.

@m3d
Copy link
Contributor Author

m3d commented May 19, 2021

A workaround is to set very high near clip distance, e.g. 0.5 m was usually enough, but the you lose depth measurements if you get closer than that...

Another stupid question - is it possible to do it on simulation side? Or do you mean to drop whole image or part of the image "once a while"? Is there some service like the newest set_rate??

@peci1
Copy link
Collaborator

peci1 commented May 19, 2021

This would have to be set in the SDF. If running locally, you can edit the SDF in ~/.ignition/fuel .

@m3d
Copy link
Contributor Author

m3d commented May 19, 2021

OK, thanks - so no chance on CloudSim?

@peci1
Copy link
Collaborator

peci1 commented May 19, 2021

I think this is a regular bug so you can try submitting a fix for it.

@peci1
Copy link
Collaborator

peci1 commented May 19, 2021

Do you know what the clipped values are? Are they NaN, Inf or something else?

@m3d
Copy link
Contributor Author

m3d commented May 20, 2021

Do you know what the clipped values are? Are they NaN, Inf or something else?

well, I have only indirect logs, as the depth is converted to 16bit millimeters and

>>> depth
array([[1, 1, 1, ..., 1, 1, 1],
       [1, 1, 1, ..., 1, 1, 1],
       [1, 1, 1, ..., 1, 1, 1],
       ...,
       [1, 1, 1, ..., 1, 1, 1],
       [1, 1, 1, ..., 1, 1, 1],
       [1, 1, 1, ..., 1, 1, 1]], dtype=uint16)

which is after

>>> np.clip(float('inf'), 1, 0xFFFF)
65535.0
>>> np.clip(float('-inf'), 1, 0xFFFF)
1.0
>>> np.clip(float('nan'), 1, 0xFFFF)
nan

and then conversion to uint16

>>> arr = np.array([float('nan')])
>>> np.ndarray.astype(arr, dtype=np.dtype('H'))
array([0], dtype=uint16)

So I suppose that it was -inf for up pointing camera.

@m3d
Copy link
Contributor Author

m3d commented Jun 29, 2021

@nkoenig is there a plan to fix this before the first SubT code freeze? Thanks m.

@knoedler
Copy link
Contributor

#960 will fix a lot of what you are seeing with the top camera. The camera is occluded by the visual.

@m3d
Copy link
Contributor Author

m3d commented Jun 30, 2021

@knoedler thanks for hope :-)

@angelacmaio
Copy link
Contributor

#960 was merged

@m3d
Copy link
Contributor Author

m3d commented Jul 7, 2021

it was merged but not released?! (which may change today or tomorrow)

@malcolmst
Copy link

any information on when this will be released?

@malcolmst
Copy link

@angelacmaio @nkoenig sorry to be a pain about this, but whether or not #960 will be released before the upcoming submission deadline will affect my work planning significantly, so if you have any information on this it would be greatly appreciated. Thanks!

@m3d
Copy link
Contributor Author

m3d commented Jul 14, 2021

This issue seems to be really gone with release 2021-07-13, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants