Backport sdf6: Move recursiveSameTypeUniqueNames from ign.cc to parser.cc #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.cc Backport of sdf9 PR 606 https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/pull-requests/606 Commit: 2d1bc56 Signed-off-by: Jose Luis Rivero <[email protected]>
j-rivero
added a commit
to gazebosim/gazebo-classic
that referenced
this pull request
Jun 3, 2021
This requires SDFormat API change gazebosim/sdformat#580.
|
something weird happened to github actions. Close and reopen to trigger them. |
jennuine
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Backport of sdf9 PR 606 https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/pull-requests/606
Corresponding commit: 2d1bc56
Test it
The backport include its own test
Checklist
sh tools/code_check.sh)Note to maintainers: Remember to use Squash-Merge