Error when delimiter "::" found in element name in SDFormat 1.8 #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenn Nguyen <[email protected]>
scpeters
requested changes
Mar 16, 2021
Signed-off-by: Jenn Nguyen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 66 66
Lines 9321 9347 +26
=======================================
+ Hits 8185 8208 +23
- Misses 1136 1139 +3
Continue to review full report at Codecov.
|
scpeters
approved these changes
Mar 17, 2021
src/parser_TEST.cc
Outdated
| << " </model>" | ||
| << "</sdf>"; | ||
|
|
||
| EXPECT_FALSE(sdf::readString(stream.str(), sdf)); |
There was a problem hiding this comment.
nit: you could pass an sdf::Errors object to sdf::readString and check its contents
Signed-off-by: Jenn Nguyen <[email protected]>
|
Waiting for #504 to be merged before merging this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #420
Summary
Error when the
::delimiter is found innameattributes for files that are SDFormat >= 1.8Checklist
sh tools/code_check.sh)another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge