Replace PROJECT_SOURCE_DIR in tests #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
force-pushed
the
test_support_bazel
branch
from
212de38 to
e7dd7ce
Compare
This allows the test files to be loaded in a more abstracted way, so that it is less dependant on the way that CMake works. Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
test_support_bazel
branch
from
e7dd7ce to
eea81be
Compare
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf10 #460 +/- ##
=======================================
Coverage 87.78% 87.78%
=======================================
Files 62 62
Lines 9577 9577
=======================================
Hits 8407 8407
Misses 1170 1170 Continue to review full report at Codecov.
|
azeey
requested changes
Jan 14, 2021
There was a problem hiding this comment.
Thanks @mjcarroll. This is great! Makes tests a lot cleaner.
scpeters
reviewed
Jan 14, 2021
test/test_config.h.in
Outdated
| bool ProjectSourcePath(std::string &_sourceDir) | ||
| { | ||
| // Bazel builds set TEST_SRCDIR | ||
| if(char* dataDir = std::getenv("TEST_SRCDIR")) |
There was a problem hiding this comment.
windows CI doesn't like this getenv call
'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
https://build.osrfoundation.org/job/sdformat-ci-pr_any-windows7-amd64/1825/msbuild/
This adds some environment variable manipulation functions from ignition::common. These may be deprecated when sdformat and ignition::common have a common dependency in ignition::utils. Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
test_support_bazel
branch
from
cb01c38 to
9a5cc57
Compare
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
test_support_bazel
branch
from
7134002 to
2bee092
Compare
Signed-off-by: Michael Carroll <[email protected]>
azeey
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the test files to be loaded in a more abstracted way,
so that it is less dependant on the way that CMake works.
Signed-off-by: Michael Carroll [email protected]