Add cmake option to disable console logfile #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sdf10 #348 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 60 60
Lines 9207 9207
=======================================
Hits 8043 8043
Misses 1164 1164
Continue to review full report at Codecov.
|
chapulina
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @azeey)
The sdf::Console class logs some messages to a file in ~/.sdformat/sdformat.log by default. This wraps the code in the constructor of the sdf::Console class that opens this file in an `#ifndef` and adds a cmake option `SDFORMAT_DISABLE_CONSOLE_LOGFILE` to easily disable the use of this logfile. Initial approach to gazebosim#334. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
force-pushed
the
disable_console_logfile
branch
from
a0c48aa to
f058a0a
Compare
I've added some documentation in |
mjcarroll
approved these changes
Sep 4, 2020
azeey
pushed a commit
to azeey/sdformat
that referenced
this pull request
Dec 9, 2020
The sdf::Console class logs some messages to a file in `~/.sdformat/sdformat.log` by default. This wraps the code in the constructor of the `sdf::Console` class that opens this file in an `#ifndef` and adds a cmake option `SDFORMAT_DISABLE_CONSOLE_LOGFILE` to easily disable the use of this logfile. Initial approach to gazebosim#334. Signed-off-by: Steve Peters <[email protected]>
brawner
pushed a commit
that referenced
this pull request
Dec 11, 2020
The sdf::Console class logs some messages to a file in `~/.sdformat/sdformat.log` by default. This wraps the code in the constructor of the `sdf::Console` class that opens this file in an `#ifndef` and adds a cmake option `SDFORMAT_DISABLE_CONSOLE_LOGFILE` to easily disable the use of this logfile. Initial approach to #334. Signed-off-by: Steve Peters <[email protected]>
brawner
pushed a commit
that referenced
this pull request
Jan 9, 2021
The sdf::Console class logs some messages to a file in `~/.sdformat/sdformat.log` by default. This wraps the code in the constructor of the `sdf::Console` class that opens this file in an `#ifndef` and adds a cmake option `SDFORMAT_DISABLE_CONSOLE_LOGFILE` to easily disable the use of this logfile. Initial approach to #334. Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sdf::Consoleclass logs some messages to a file in ~/.sdformat/sdformat.log by default. This wraps the code in the constructor of thesdf::Consoleclass that opens this file in an#ifndefand adds a cmake optionSDFORMAT_DISABLE_CONSOLE_LOGFILEto easily disable the use of this logfile.Initial approach to #334.