Link privately to TinyXML2 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
|
Looking into Linux failing tests - Fixed |
…nst it Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf10 #321 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 60 60
Lines 9085 9085
=======================================
Hits 7950 7950
Misses 1135 1135 Continue to review full report at Codecov.
|
scpeters
reviewed
Jul 25, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
approved these changes
Jul 25, 2020
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
added a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Louise Poubel <[email protected]>
scpeters
added a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TinyXML2 is not exposed on SDFormat's public API, so it can be linked to privately.
This fixes compilation of Ignition Physics on Windows, see gazebosim/gz-physics#85.
Here's
ign-physics3Windows CI using this branch: