-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observe the CMake variable BUILD_TESTING if it is defined #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <[email protected]>
chapulina
approved these changes
May 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
traversaro
changed the title
If defined observe the CMake variable BUILD_TESTING
If it is defined observe the CMake variable BUILD_TESTING
May 2, 2020
scpeters
approved these changes
May 15, 2020
scpeters
changed the title
If it is defined observe the CMake variable BUILD_TESTING
Observe the CMake variable BUILD_TESTING if it is defined
May 15, 2020
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
May 18, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
May 28, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Jul 7, 2020
) For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Jul 7, 2020
) For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <[email protected]> Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Jul 9, 2020
For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <[email protected]> Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Jul 9, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
pushed a commit
to scpeters/sdformat
that referenced
this pull request
Jul 17, 2020
) For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <[email protected]> Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Jul 17, 2020
Signed-off-by: Steve Peters <[email protected]>
scpeters
pushed a commit
that referenced
this pull request
Jul 21, 2020
For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <[email protected]> Signed-off-by: Steve Peters <[email protected]>
scpeters
added a commit
that referenced
this pull request
Jul 21, 2020
Signed-off-by: Steve Peters <[email protected]>
traversaro
added a commit
to traversaro/sdformat
that referenced
this pull request
Sep 5, 2020
) For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <[email protected]>
traversaro
pushed a commit
to traversaro/sdformat
that referenced
this pull request
Sep 5, 2020
Signed-off-by: Steve Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backward compatibility if the BUILD_TESTING variable is not defined compile the tests.
Fix #208 .
In particular on Windows the test takes a long time to compile due to the embedde tinyxml that is recompiled for each test.