Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2/3 version conflict #69

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Python 2/3 version conflict #69

merged 1 commit into from
Nov 30, 2020

Conversation

jspricke
Copy link
Contributor

Both provide the same files. This is needed to upgrade from Ubuntu 18 to
20.

Both provide the same files. This is needed to upgrade from Ubuntu 18 to
20.
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, but I'm not that familiar with stdeb stuff. So I'll approve, but wait for someone else to also approve and merge.

@jspricke
Copy link
Contributor Author

jspricke commented Oct 5, 2020

@clalancette me neither, but there is a similar construct here ;): https://github.com/ros-infrastructure/catkin_pkg/blob/master/stdeb.cfg#L12

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, sorry for the delay

@wjwwood wjwwood merged commit af40569 into osrf:master Nov 30, 2020
@jspricke jspricke deleted the add_conflicts branch December 1, 2020 07:17
@wjwwood
Copy link
Member

wjwwood commented Feb 27, 2021

Actually wait, why do we need this? I thought that as long as it was just the python module, it would be separated by the different python site paths. @jspricke Are there particular files which are colliding?

@jspricke
Copy link
Contributor Author

Both ship:

/usr/share/ament_index/resource_index/packages/osrf_pycommon
/usr/share/osrf_pycommon/package.xml

So if you want to upgrade from a bionic system with python-osrf-pycommon installed, you get:

Unpacking python3-osrf-pycommon (0.1.9-1) ...
dpkg: error processing archive /tmp/apt-dpkg-install-KldBzT/5-python3-osrf-pycommon_0.1.9-1_all.deb (--unpack):
 trying to overwrite '/usr/share/ament_index/resource_index/packages/osrf_pycommon', which is also in package python-osrf-pycommon 0.1.9-1
Errors were encountered while processing:
 /tmp/apt-dpkg-install-KldBzT/5-python3-osrf-pycommon_0.1.9-1_all.deb

With the conflict in place apt will remove python-osrf-pycommon before unpacking python3-osrf-pycommon and you can upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants