You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed here #82 (comment) , there is a circular dependency between lrauv-application (MBARI repo) and lrauv_ignition_plugins package.
MBARI repo depends on the compiled protobuf message headers in lrauv_ignition_plugins. lrauv_ignition_plugins depends on the MBARI repo for automated mission tests.
Verbally, we agreed on refactoring the custom protobuf messages to a lrauv_msgs package.
Then lrauv-application would depend on lrauv_msgs. lrauv_ignition_plugins would depend on lrauv_msgs and lrauv-application.
That solves the circular dependency.
Style of field names
As discussed here #90 (comment) , we want to eliminate the trailing underscores of the field names, and to change to snake_case.
This applies to LRAUVState, LRAUVCommand, and LRAUVInit.
The text was updated successfully, but these errors were encountered:
dropWeightState_ is used. That's the only field for drop weight – it doesn't have an action field. It's a state as opposed to an action because on the real vehicle, it's an indicator meaning "it's been dropped. Goner."
The 5 other fields, if I remember correctly, are what the MBARI controller thinks the positions of the actuators are. The Ignition side doesn't use those at the moment. They become useful if there is a mismatch between where the controller thinks the actuators are, and where the simulator's state thinks the actuators are, which can be due to time sync issues, physics instability at a very fast time step, etc. @braanan can correct me.
Tasks in this ticket, elaborated below.
Refactor to lrauv_msgs
As discussed here #82 (comment) , there is a circular dependency between
lrauv-application
(MBARI repo) andlrauv_ignition_plugins
package.MBARI repo depends on the compiled protobuf message headers in
lrauv_ignition_plugins
.lrauv_ignition_plugins
depends on the MBARI repo for automated mission tests.Verbally, we agreed on refactoring the custom protobuf messages to a
lrauv_msgs
package.Then
lrauv-application
would depend onlrauv_msgs
.lrauv_ignition_plugins
would depend onlrauv_msgs
andlrauv-application
.That solves the circular dependency.
Style of field names
As discussed here #90 (comment) , we want to eliminate the trailing underscores of the field names, and to change to
snake_case
.This applies to
LRAUVState
,LRAUVCommand
, andLRAUVInit
.The text was updated successfully, but these errors were encountered: