Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract pressure sensor out of TethysCommPlugin #30

Open
mabelzhang opened this issue Sep 23, 2021 · 1 comment
Open

Extract pressure sensor out of TethysCommPlugin #30

mabelzhang opened this issue Sep 23, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@mabelzhang
Copy link
Collaborator

As verbally discussed, ocean pressure, added in #91 to TethysCommPlugin in the interest of time, should be extracted into its own custom sensor, along with other science sensors in ScienceSensorsSystem.cc, for upstreaming to ign-gazebo.

Note that until longitude/latitude are implemented, the output is meaningless, because pressure is computed from latitude and depth.

Science sensor data can then be packaged (by us or end users) into a CTD (conductivity, temperature, depth) sensor, which requires salinity (gives conductivity), temperature, and depth (calculated from pressure, but can be ground truth from simulation).

@mabelzhang
Copy link
Collaborator Author

Do as part of #100 while upstreaming

@chapulina chapulina transferred this issue from another repository Nov 2, 2021
@mabelzhang mabelzhang added the good first issue Good for newcomers label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant