Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for building bottles for new macOS version #1695

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Docs for building bottles for new macOS version #1695

merged 7 commits into from
Nov 30, 2021

Conversation

scpeters
Copy link
Member

@scpeters scpeters requested a review from j-rivero November 25, 2021 01:33
@scpeters scpeters mentioned this pull request Nov 25, 2021
Merged
j-rivero
j-rivero approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks great

@scpeters scpeters mentioned this pull request Nov 29, 2021
Merged
@scpeters scpeters merged commit 37bb0a8 into osrf:master Nov 30, 2021
@scpeters scpeters deleted the readme_build_for_new_distro branch November 30, 2021 22:35
@scpeters
Copy link
Member Author

I merged this without updating the syntax. I'll submit a follow-up

@scpeters
Copy link
Member Author

scpeters commented Dec 1, 2021

I merged this without updating the syntax. I'll submit a follow-up

never mind, the syntax is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @j-rivero