Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify which Node versions are supported in the tutorial #173

Open
osrf-migration opened this issue Mar 16, 2020 · 5 comments
Open
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Anonymous.


The tutorial states that it supports "NodeJS version 4 or higher."
This isn't accurate since I was unable to build gzweb for node v12.16.1 (LTS).
I would get an error stating that "v8::Handle is not defined".

@osrf-migration
Copy link
Author

Original comment by Anas Abouallaban (Bitbucket: Anas Abouallaban).


Forgot to put my system info:

OS: Ubuntu 18.04
ROS Melodic
Gazebo v9

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


You're talking about this tutorial, right? Thanks for the note. The tutorial has an Edit button on the top. It would be great if you could open a pull request modifying the tutorial to mention the maximum supported version. Thanks!

@osrf-migration
Copy link
Author

Original comment by Yifeng Ni (Bitbucket: Yifeng Ni).


i think the node v12.6.2 also have the similar mistakes on building .

../GZNode.cc: At global scope:
../GZNode.cc:289:14: error: variable or field ‘InitAll’ declared void
void InitAll(Handle exports)
^
../GZNode.cc:289:14: error: ‘Handle’ was not declared in this scope
../GZNode.cc:289:27: error: expected primary-expression before ‘>’ token
void InitAll(Handle exports)
^
../GZNode.cc:289:29: error: ‘exports’ was not declared in this scope
void InitAll(Handle exports)
^
In file included from ../GZNode.cc:18:0:
../GZNode.cc:295:23: error: ‘InitAll’ was not declared in this scope
NODE_MODULE(gzbridge, InitAll)
^
/home/nyf1209/.cache/node-gyp/12.16.2/include/node/node.h:608:36: note: in definition of macro ‘NODE_MODULE_X’
(node::addon_register_func) (regfunc),
^
../GZNode.cc:295:1: note: in expansion of macro ‘NODE_MODULE’
NODE_MODULE(gzbridge, InitAll)

@osrf-migration
Copy link
Author

Original comment by Yifeng Ni (Bitbucket: Yifeng Ni).


here the problem i meet now , i can build the project use node version 8.x and 6.x but after building , when i run the gzweb using npm start , the problem comes out such that the

NODE_MODULE_VERSION 48. This version of Node.js requires
NODE_MODULE_VERSION 72. Please try re-compiling or re-installing

comes out , when i go back to check the node_module version of every node package, only the node v12.x has the version 72 , however, the module can’t compile using that version which seems the problem is unsolvable for me.

my system info: ros Kinetic

ubuntu 16.04

gazebo v10

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 25, 2020
@mis-eu
Copy link

mis-eu commented Oct 19, 2020

Ubuntu 20.04 Focal / ROS2 Foxy / Gazebo 11 builds specifically gzweb 1.3.0
with these 2 patches applied deploy.sh and binding.gyp from branch: eurogroep@696148d
against:
Node v10.19.0
npm 6.14.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

2 participants