Add symbol visibility information to all the functions that are exported #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the symbol visibility information to the main API functions that QDLDL exports so that they are exposed inside shared libraries on all platforms. This is mainly an issue on Windows (which defaults to exporting no symbols in a shared library), but could also be a problem if someone tries to use the flag
-fvisibility=hidden
on other platforms.Before this change (compiled with
-fvisibility=hidden
),readelf -Ws out/libqdldl.so
shows:After this change (compiled with
-fvisibility=hidden
still),readelf -Ws out/libqdldl.so
shows:I am marking as a draft since I still want to do some testing on platforms other than Linux.