Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Wanted: Adding a column to the differences table #631

Closed
andersonfrailey opened this issue Aug 21, 2017 · 6 comments
Closed

Help Wanted: Adding a column to the differences table #631

andersonfrailey opened this issue Aug 21, 2017 · 6 comments

Comments

@andersonfrailey
Copy link
Contributor

In Tax-Calculator PR #1375 I added a column to the differences table to show percent change in after tax income. This was included in the 0.8.5 release, but it hasn't been added to TaxBrain yet. @hdoupe and I tried to get it working today but couldn't. If anyone could help us out with this I would greatly appreciate it.

@MattHJensen
Copy link
Contributor

To handle backwards compatibility, one option would be to leave this column blank for past runs.

@hdoupe
Copy link
Collaborator

hdoupe commented Aug 21, 2017

@andersonfrailey do you want to open a PR for the changes in dropq.py and dropq_utils.py that we talked about? Then those changes would be incorporated in taxcalc 0.9.3 and as soon as TaxBrain is using taxcalc 0.9.3 the continuum team or one of us can take another crack at making the necessary webapp changes. Does that make sense?

@andersonfrailey
Copy link
Contributor Author

@hdoupe, that makes sense. I'll open it up so people can see our thought process.

@andersonfrailey
Copy link
Contributor Author

Here is said PR

@MattHJensen
Copy link
Contributor

@andersonfrailey, should this issue be closed?

@andersonfrailey
Copy link
Contributor Author

@MattHJensen yes. This has been taken care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants