fix: config overwrite ignores app.toml values #7233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/backport
p0mvn
force-pushed
the
roman/fix-config-overwrite
branch
from
592d7a8 to
06cf429
Compare
p0mvn
added
A:backport/v21.x
p0mvn
added
A:backport/v21.x
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
(cherry picked from commit 759eaf2)
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Previous PR that created config overwrite caused
app.tomlvalues being dropped when starting uposmosisd. This PR fixes the issue by creating a new viper copy that loads theconfig.tomlvalues while preserving the original contents.Testing and Verifying
Tested locally
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)