Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a field to pools to allow specifying governer #64

Closed
ValarDragon opened this issue Apr 2, 2021 · 0 comments · Fixed by #92
Closed

Add a field to pools to allow specifying governer #64

ValarDragon opened this issue Apr 2, 2021 · 0 comments · Fixed by #92
Assignees
@xbuidler
Labels
C:x/gamm Changes, features and bugs related to the gamm module. feature New feature or request

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Apr 2, 2021 •
edited
Loading

After #60, we have no way for a pool to specify who its future governor will be, once we build support for it.

Lets add a string for "Future owner of a pool". This can be an address, or a This LP Token, lockup time pair. We then need to build a "validate owner string" function.

Then next upgrade when we implement pool-specific governance, we automatically port the governor specification from this string.

Originally posted by @ValarDragon in #60 (comment)
@sunnya97 sunnya97 added feature New feature or request C:x/gamm Changes, features and bugs related to the gamm module. labels Apr 2, 2021
@xbuidler xbuidler mentioned this issue Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xbuidler xbuidler

Labels
C:x/gamm Changes, features and bugs related to the gamm module. feature New feature or request
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

future pool governer string set osmosis-labs/osmosis
3 participants
@sunnya97 @ValarDragon @xbuidler