Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Record to PoolAssetType #70

Closed
ValarDragon opened this issue Apr 5, 2021 · 0 comments · Fixed by #75
Closed

Rename Record to PoolAssetType #70

ValarDragon opened this issue Apr 5, 2021 · 0 comments · Fixed by #75
Assignees
@ValarDragon
Labels
api-breaking Breaking changes that impact API only (not state machine). T:code-hygiene

Comments

@ValarDragon
Copy link
Member

Record in the pools currently refers to an (asset_denom, weight) pair. I believe the name record is fairly misleading for this.

I suggest we rename Record to PoolAssetType. (Or perhaps a better name if anyone can think of one)
@ValarDragon ValarDragon added api-breaking Breaking changes that impact API only (not state machine). T:code-hygiene labels Apr 5, 2021
@ValarDragon ValarDragon self-assigned this Apr 6, 2021
@ValarDragon ValarDragon mentioned this issue Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValarDragon ValarDragon

Labels
api-breaking Breaking changes that impact API only (not state machine). T:code-hygiene
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename Record to PoolAsset osmosis-labs/osmosis
1 participant
@ValarDragon