Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: total liquidity poolmanager grpc gateway query #6941

Closed
p0mvn opened this issue Nov 28, 2023 · 1 comment · Fixed by #6991
Closed

fix: total liquidity poolmanager grpc gateway query #6941

p0mvn opened this issue Nov 28, 2023 · 1 comment · Fixed by #6991
Labels
Help wanted T:bug 🐛 Something isn't working

Comments

@p0mvn
Copy link
Member

p0mvn commented Nov 28, 2023

Background

We need to fix the path to avoid overlapping with pools:

osmosis/proto/osmosis/poolmanager/v1beta1/query.proto

Lines 115 to 119 in 8be655f

// TotalLiquidity returns the total liquidity across all pools.
rpc TotalLiquidity(TotalLiquidityRequest) returns (TotalLiquidityResponse) {
option (google.api.http).get =
"/osmosis/poolmanager/v1beta1/pools/total_liquidity";
}

Similar fix to: #6939

A/C

  • Fix implemented
  • Test on localosmosis
@p0mvn p0mvn added T:bug 🐛 Something isn't working Help wanted labels Nov 28, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Nov 28, 2023
@DongLieu
Copy link
Contributor

can i handle it?

This was referenced Nov 29, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted T:bug 🐛 Something isn't working
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
2 participants
@p0mvn @DongLieu