You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This means that, if a gov prop attempts to call a hook, it will not be registered and will panic.
One way to fix this is to decouple the route setting from the govKeeper itself, and call the route setting after we setup the hooks.
Suggested Design
Refrain from any sdk fork changes until we unfork ourselves to 0.47. I believe routes get removed in 0.47. If it does not and this is still an issue, we should open up an issue in the sdk to fix this.
Acceptance Criteria
TBD
The text was updated successfully, but these errors were encountered:
Background
The order of initialization is as follows:
osmosis/app/app.go
Line 233 in 5ab084a
osmosis/app/keepers/keepers.go
Lines 500 to 515 in 5ab084a
osmosis/app/app.go
Line 244 in 5ab084a
This means that, if a gov prop attempts to call a hook, it will not be registered and will panic.
One way to fix this is to decouple the route setting from the govKeeper itself, and call the route setting after we setup the hooks.
Suggested Design
Refrain from any sdk fork changes until we unfork ourselves to 0.47. I believe routes get removed in 0.47. If it does not and this is still an issue, we should open up an issue in the sdk to fix this.
Acceptance Criteria
TBD
The text was updated successfully, but these errors were encountered: