Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add message for transferring CL position ownership #6541

Closed
Tracked by #5864
p0mvn opened this issue Sep 26, 2023 · 1 comment · Fixed by #6623
Closed
Tracked by #5864

feat: add message for transferring CL position ownership #6541

p0mvn opened this issue Sep 26, 2023 · 1 comment · Fixed by #6623
Assignees
@czarcas7ic
Labels
C:x/concentrated-liquidity T:triage Issues that need to be prioritized

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 26, 2023

Background

We need a message for transferring CL position ownership.

Suggested Design

  • Implement MsgTransferPosition
  • Under the hood withdraws the position and creates it on behalf of receiver
  • Add spam prevention mechanism of min USD value to be eligible for tansfer
  • Consider special casing community pool to bypass restriction

Acceptance Criteria

  • Message implemented
  • Unit tested
  • Local osmosis tested
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Sep 26, 2023
@p0mvn p0mvn mentioned this issue Sep 26, 2023
Closed
@pysel
Copy link
Member

pysel commented Sep 26, 2023

Add spam prevention mechanism of min USD value to be eligible for tansfer

asking to learn: doesn't the required gas paid for this transaction already prevents potential spam attacks?

@p0mvn p0mvn added the T:triage Issues that need to be prioritized label Sep 26, 2023
@czarcas7ic czarcas7ic self-assigned this Sep 28, 2023
@czarcas7ic czarcas7ic mentioned this issue Oct 3, 2023
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czarcas7ic czarcas7ic

Labels
C:x/concentrated-liquidity T:triage Issues that need to be prioritized
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: transfer cl position to new owner osmosis-labs/osmosis
3 participants
@p0mvn @czarcas7ic @pysel