Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VS Incentives]: Refactor CreateGroupGauge to take in a list of pool IDs instead of gauge IDs #6404

Closed
Tracked by #6057
AlpinYukseloglu opened this issue Sep 14, 2023 · 0 comments · Fixed by #6525
Closed
Tracked by #6057
Assignees
Labels
F: volume-splitting feat: Volume-splitting incentives

Comments

@AlpinYukseloglu
Copy link
Contributor

AlpinYukseloglu commented Sep 14, 2023

Background

Since group gauge logic heavily leans on there being a pool linked to each internal gauge and since we want the top level message to take in a list of pool IDs to split between, CreateGroupGauge should be refactored to take in a list of pool IDs instead of gauge IDs. This could likely be done in conjunction with #6401, which also deals with pool IDs.

Suggested Design

Acceptance Criteria

  • Group gauge creation logic is complete and well tested
  • Test skips and TODOs are removed from relevant tests in x/incentives/keeper/gauge_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: volume-splitting feat: Volume-splitting incentives
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants