You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In v15, we configured the rate limiting contract via upgrade handler.
Now, that we are performing the upgrade from v15 to v16 in #4575 , the v15 upgrade handler code is not going to run. As a result, we need to configure the contract in the genesis from an updated image
To do this, we would need the rate limiting module to have access to a ContractKeeper with higher permissions (so it can instantiate the contract on genesis). This is easy enough to do, but expands the permissions of the module unnecessarily.
Does it make more sense to just remove this test on e2e? I don't think we need it. If we want to test intearactions with RL, we can instantiate a new contract in the test and configure it specifically for that.
Does it make more sense to just remove this test on e2e? I don't think we need it. If we want to test intearactions with RL, we can instantiate a new contract in the test and configure it specifically for that.
Thanks for looking into it. This makes sense to me
Background
In v15, we configured the rate limiting contract via upgrade handler.
Now, that we are performing the upgrade from v15 to v16 in #4575 , the v15 upgrade handler code is not going to run. As a result, we need to configure the contract in the genesis from an updated image
Suggested Design
Acceptance Criteria
The text was updated successfully, but these errors were encountered: