Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL Incentives] Remove ability to add to frozen positions #4482

Closed
Tracked by #3991
AlpinYukseloglu opened this issue Mar 2, 2023 · 1 comment
Closed
Tracked by #3991

[CL Incentives] Remove ability to add to frozen positions #4482

AlpinYukseloglu opened this issue Mar 2, 2023 · 1 comment
Assignees
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Now that we key positions by joinTime and freezeDuration, it is no longer possible for people to add to an existing position. While we might still want to special-case non-frozen positions to save state, we should at the very least remove unnecessary code complexity from updates for uptime accumulators.

Suggested Design

  • initOrUpdatePositionUptime -> initPositionUptime
  • Return error if record exists and last pool update is Before current blocktime
    • This is to ensure that users can create multiple txs in the same block (although not sure why we wouldn't just error here)

Acceptance Criteria

  • New and existing tests pass
@AlpinYukseloglu AlpinYukseloglu added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Mar 2, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Mar 2, 2023
@stackman27 stackman27 self-assigned this Mar 6, 2023
@p0mvn p0mvn moved this from Needs Triage 🔍 to Needs PR Review in Osmosis Chain Development Mar 26, 2023
@stackman27
Copy link
Contributor

Completed ##4508

@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
Development

No branches or pull requests

2 participants