Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL Incentives]: Sync global uptime accumulators upon tick crossing #4278

Closed
Tracked by #3991
AlpinYukseloglu opened this issue Feb 9, 2023 · 0 comments · Fixed by #4399
Closed
Tracked by #3991

[CL Incentives]: Sync global uptime accumulators upon tick crossing #4278

AlpinYukseloglu opened this issue Feb 9, 2023 · 0 comments · Fixed by #4399
Assignees
@AlpinYukseloglu
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Milestone
CL 9

Comments

@AlpinYukseloglu
Copy link
Contributor

Background

Once tick initialization logic is set up for tick-level accum uptime trackers, we need to implement the necessary logic for accommodating tick crossing.

Suggested Design

  • Upon tick crossing, we should subtract the uptime tracker values of the tick we are entering from the tick we came from, as implemented here: c318fa0

Acceptance Criteria

  • All new and existing tests pass
@AlpinYukseloglu AlpinYukseloglu added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Feb 9, 2023
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Feb 9, 2023
This was referenced Feb 9, 2023
Closed
Merged
@AlpinYukseloglu AlpinYukseloglu mentioned this issue Feb 23, 2023
Merged
@AlpinYukseloglu AlpinYukseloglu self-assigned this Feb 23, 2023
@p0mvn p0mvn added this to the CL 9 milestone Feb 28, 2023
@p0mvn p0mvn removed the T:ice-box label Mar 2, 2023
@AlpinYukseloglu AlpinYukseloglu moved this from Needs Triage 🔍 to In Progress🏃 in Osmosis Chain Development Mar 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlpinYukseloglu AlpinYukseloglu

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 9
Development

Successfully merging a pull request may close this issue.

[CL Incentives]: Sync global uptime accumulators upon tick crossing osmosis-labs/osmosis
2 participants
@p0mvn @AlpinYukseloglu