Panic Handling In MultihopEstimateOutGivenExactAmountIn borks Protorev

[NotJeremyLiu]

Background

Panics are caught when swapping (https://github.com/osmosis-labs/osmosis/blob/main/x/gamm/keeper/swap.go#L39-L44) but not when estimating a swap (

osmosis/x/poolmanager/router.go

Line 133 in d28c741

func (k Keeper) MultihopEstimateOutGivenExactAmountIn(

).

The specific panic that brought this to our attention for Protorev was in stableswap solveCFMMBinarySearchMulti: (

osmosis/x/gamm/pool-models/stableswap/amm.go

Line 315 in d28c741

panic("cannot input more than pool reserves")

), but generally any of these panics could likely cause an issue if MultihopEstimateOutGivenExactAmountIn does not catch the panics.

Suggested Design

We are open to different forms of resolution, whether that may be core team adding panic catching in MultihopEstimateOutGivenExactAmountIn or us catching panics in Protorev, but we are waiting for core team decision on best way forward.

Acceptance Criteria

All current protorev tests pass, and adding new tests to purposefully trigger the panics does not result in the actual panic to cause a halt.

[ValarDragon]

I think we should definitely just catch this panic -- quite silly for estimate to panic haha