Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination support for AllIntermediaryAccounts query in Superfluid Module #4168

Closed
Tracked by #4624
mattverse opened this issue Jan 31, 2023 · 1 comment · Fixed by #4752
Closed
Tracked by #4624

Add pagination support for AllIntermediaryAccounts query in Superfluid Module #4168

mattverse opened this issue Jan 31, 2023 · 1 comment · Fixed by #4752
Labels
T:ice-box T:ice-box-queries

Comments

@mattverse
Copy link
Member

Background

Noticed that we have pagination for the AllIntermediaryAccounts query in the superfluid module proto definitions((cref:https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/superfluid/query.proto#L154-L161), but we're not correctly supporting pagination for the query(https://github.com/osmosis-labs/osmosis/blob/main/x/superfluid/keeper/grpc_query.go#L89-L106)

Suggested Design

Add support for pagination for this query, examples of using pagination can be found in the gamm module or the incentives module.

Acceptance Criteria

  • Pagination support for AllIntermediaryAccounts query in Superfluid module has been added
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 31, 2023
@czarcas7ic czarcas7ic mentioned this issue Mar 14, 2023
Closed
@DongLieu
Copy link
Contributor

Can i handle it?

@DongLieu DongLieu mentioned this issue Mar 27, 2023
Merged
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:ice-box T:ice-box-queries
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dong/pagination for all intermediary accounts notional-labs/osmosis
3 participants
@czarcas7ic @mattverse @DongLieu