Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL Incentives] Uptime Accumulator Initialization #4112

Closed
Tracked by #3991
AlpinYukseloglu opened this issue Jan 27, 2023 · 0 comments · Fixed by #4124
Closed
Tracked by #3991

[CL Incentives] Uptime Accumulator Initialization #4112

AlpinYukseloglu opened this issue Jan 27, 2023 · 0 comments · Fixed by #4124
Assignees
@AlpinYukseloglu
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@AlpinYukseloglu
Copy link
Contributor

AlpinYukseloglu commented Jan 27, 2023 •
edited
Loading

Background

Upon pool creation, each supported uptime should have one pool-wide accumulator initialized to zero.

Suggested Design

  • Track an []sdk.Dec of accumulators, initialized with len(SupportedUptimes) ones upon pool creation
  • Reserve accumulator value of zero for positions who are not eligible for the uptime rewards (e.g. if a position's accum value for the 1 week uptime is 0, this is considered "uninitialized")

Alternatively: make the accumulator API work for this setup

Acceptance Criteria

  • New and existing CL tests pass
@AlpinYukseloglu AlpinYukseloglu added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jan 27, 2023
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 27, 2023
This was referenced Jan 27, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jan 30, 2023
@AlpinYukseloglu AlpinYukseloglu mentioned this issue Jan 30, 2023
Closed
32 tasks
@AlpinYukseloglu AlpinYukseloglu self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlpinYukseloglu AlpinYukseloglu

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CL Incentives] Uptime Accumulator Initialization osmosis-labs/osmosis
1 participant
@AlpinYukseloglu