Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL Fees]: Fee - Misc tracking issue #4096

Closed
7 tasks done
Tracked by #3074
p0mvn opened this issue Jan 25, 2023 · 2 comments · Fixed by #4777
Closed
7 tasks done
Tracked by #3074

[CL Fees]: Fee - Misc tracking issue #4096

p0mvn opened this issue Jan 25, 2023 · 2 comments · Fixed by #4777
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Milestone
CL 8: Fees, Pool ...

Comments

@p0mvn
Copy link
Member

p0mvn commented Jan 25, 2023 •
edited
Loading

Background

This issue consists of misc TODOs that we should revisit before finalizing the fees user story.

Suggested Design

  • index positions by strings in the accum module. Make sure that CL
    positions are indexed by pool, owner and tick range.
  • make sure accumulator module allows for prefixes that preserve data locality.
  • try moving fees logic into the internal package
  • figure out how to make calcs non-mutative
  • make sure fees are updated in the right places
  • document that if we withdraw all shares, the rewards are claimed and the
    fee accumulator position is deleted. As a result, next time we add liqudity for the same
    ticks, we need to re-initialzie the
  • remove prints for swaps

Acceptance Criteria

  • all TODOs above are addressed
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jan 25, 2023
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 25, 2023
This was referenced Jan 25, 2023
Closed
Merged
@p0mvn p0mvn self-assigned this Feb 1, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Feb 9, 2023

Additional tracking:

@p0mvn p0mvn mentioned this issue Feb 9, 2023
Merged
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Mar 26, 2023
@p0mvn p0mvn moved this from Todo 🕒 to In Progress🏃 in Osmosis Chain Development Mar 28, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Mar 28, 2023

Confirmed that all TODOs are either addressed or obsolete

@p0mvn p0mvn mentioned this issue Mar 28, 2023
Merged
@p0mvn p0mvn moved this from In Progress🏃 to Needs PR Review in Osmosis Chain Development Mar 28, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 8: Fees, Pool Manager Module Final...
Development

Successfully merging a pull request may close this issue.

refactor: shorten fee and uptime accumulator prefixes; move to keys.go osmosis-labs/osmosis
1 participant
@p0mvn