Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(CL Fees): computeFeeChargePerStep #4087

Closed
Tracked by #3074
p0mvn opened this issue Jan 24, 2023 · 2 comments · Fixed by #4198
Closed
Tracked by #3074

test(CL Fees): computeFeeChargePerStep #4087

p0mvn opened this issue Jan 24, 2023 · 2 comments · Fixed by #4198
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Milestone
CL 8: Fees, Pool ...

Comments

@p0mvn
Copy link
Member

p0mvn commented Jan 24, 2023

Background

The following method needs to be tested:

osmosis/x/concentrated-liquidity/fees.go

Line 270 in df3853f

func computeFeeChargePerStep(currentSqrtPrice, nextSqrtPrice, sqrtPriceLimit, amountIn, amountSpecifiedRemaining, swapFee sdk.Dec) sdk.Dec {

Suggested Design

Add table driven test to maximize test coverage

Acceptance Criteria

  • test added
  • coverage maximized
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 24, 2023
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jan 24, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Jan 24, 2023

It might be that this issue ends up being obsolete after implementing swap fees for cal out given in. Making it for tracking purposes

@p0mvn
Copy link
Member Author

p0mvn commented Jan 24, 2023

Revisit after #4088 is complete

This was referenced Jan 24, 2023
Closed
Merged
@p0mvn p0mvn self-assigned this Feb 1, 2023
@p0mvn p0mvn mentioned this issue Feb 1, 2023
Merged
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 8: Fees, Pool Manager Module Final...
Development

Successfully merging a pull request may close this issue.

test(CL Fees): updateFeeGrowthGlobal osmosis-labs/osmosis
1 participant
@p0mvn