Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CL Fees): implement creating fee accumulator at pool creation #3916

Closed
p0mvn opened this issue Jan 4, 2023 · 0 comments · Fixed by #3919
Closed

feat(CL Fees): implement creating fee accumulator at pool creation #3916

p0mvn opened this issue Jan 4, 2023 · 0 comments · Fixed by #3919
Assignees
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@p0mvn
Copy link
Member

p0mvn commented Jan 4, 2023

Background

In #3893, we prototyped the concentrated liquidity fees.

Now, we need to split that PR into multiple components with tests.

This issue focuses on implementing and testing the createFeeAccumulator method and its dependencies. The method is to be called at pool creation in InitializePool.

We also need to add appropriate godocs and tests to all new logic.

Suggested Design

From #3893, we need to extract this method, add tests for it,

Next, we need to call it from InitializePool. InitializePool should also be tested to make sure that the accumulator is initialized correctly.

Relevant Resources

The following resources were used to implement the accum package that is required for implementing concentrated liquidity fees:

Dependencies

This issue is blocked on: #3903 being merged. Branch off of #3903 if starting before its completion

Acceptance Criteria

  • createFeeAccumulator helper is implemented
  • tested with coverage maximized
  • call createFeeAccumulator in InitializePool in x/concentrated-liquidity
  • tests for InitializePool added to make sure that the accumulator is initialized correctly
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jan 4, 2023
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 4, 2023
@github-project-automation github-project-automation bot moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants