Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Swap Router Module]: deprecate SwapExactAmountInDefaultSwapFee in gamm #3129

Closed
p0mvn opened this issue Oct 24, 2022 · 0 comments
Closed

[CL][Swap Router Module]: deprecate SwapExactAmountInDefaultSwapFee in gamm #3129

p0mvn opened this issue Oct 24, 2022 · 0 comments
Assignees
@mattverse
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Milestone
CL4: Precise Loga...

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 24, 2022

Background

As part of the progress to move swap logic to swap-router module, we moved the
multihop logic out from gamm.

The refactor in #3128 left gamm in an awkward state where there are two public methods doing with minimal differences:

  • SwapExactAmountInDefaultSwapFee
  • SwapExactAmountIn

Suggested Design

  • Remove SwapExactAmountInDefaultSwapFee
  • Port its tests to be against SwapExactAmountIn

Acceptance Criteria

  • method removed
  • tests are ported
  • no test coverage is missed
@p0mvn p0mvn added C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Oct 24, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 24, 2022
@p0mvn p0mvn added the T:task ⚙️ A task belongs to a story label Oct 24, 2022
This was referenced Oct 24, 2022
Closed
Merged
@mattverse mattverse self-assigned this Oct 25, 2022
@mattverse mattverse mentioned this issue Oct 25, 2022
Merged
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Projects
Osmosis Chain Development
Archived in project
Milestone
CL4: Precise Logarithm, Improved Wiri...
Development

No branches or pull requests
2 participants
@p0mvn @mattverse