Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all those apis with pagination parameters return 429? only on Osmosis. #1425

Closed
liangping opened this issue May 5, 2022 · 15 comments
Closed

Comments

@liangping
Copy link

We don't have access limit
https://osmo.api.ping.pub/cosmos/slashing/v1beta1/signing_infos?pagination.limit=5
https://lcd-osmosis.blockapsis.com/cosmos/gov/v1beta1/proposals?pagination.limit=5&pagination.reverse=true&pagination.key=

Both return this error.

{
  "code": 8,
  "message": "trying to send message larger than max (6 vs. 0)",
  "details": [
  ]
}
@p0mvn
Copy link
Member

p0mvn commented May 5, 2022

Hi @liangping

It seems to be related to new config values. Please update the following in app.toml:

max-recv-msg-size = "10485760"

max-send-msg-size = "2147483647"

These values are in bytes. Please feel free to adjust them according to your needs. Let me know if the problem persists

@liangping
Copy link
Author

Thank. Let me try it

@liangping
Copy link
Author

liangping commented May 5, 2022

@p0mvn tried in [rpc] and [api] , but not works

[grpc]

# Enable defines if the gRPC server should be enabled.
enable = true

# Address defines the gRPC server address to bind to.
address = "0.0.0.0:9090"

max-recv-msg-size = "10485760"

max-send-msg-size = "2147483647"

@ChihuahuaChain
Copy link
Contributor

@p0mvn tried in [rpc] and [api] , but not works

[grpc]

# Enable defines if the gRPC server should be enabled.
enable = true

# Address defines the gRPC server address to bind to.
address = "0.0.0.0:9090"

max-recv-msg-size = "10485760"

max-send-msg-size = "2147483647"

Tried that as well and tried to increase bytes as well, won't fix it.

@ValarDragon
Copy link
Member

Are folks having issues on all v7.x versions, or just v7.3.0?

@p0mvn
Copy link
Member

p0mvn commented May 5, 2022

@liangping @ChihuahuaChain Just FYI, I had several folks who were having this problem getting it fixed by updating these configs. Please double-check that the configs are picked up correctly. Let me know how it goes.

I will do some testing on my side today as well

@p0mvn
Copy link
Member

p0mvn commented May 5, 2022

Are folks having issues on all v7.x versions, or just v7.3.0?

I started seeing reports since v7.2.1 when osmosis-labs/cosmos-sdk#210 was released

@ChihuahuaChain
Copy link
Contributor

@liangping @ChihuahuaChain Just FYI, I had several folks who were having this problem getting it fixed by updating these configs. Please double-check that the configs are picked up correctly. Let me know how it goes.

I will do some testing on my side today as well

Checked config, values are in, service restarted and still have these problems, I started having issues only after updating to 7.3.0, no problems prior.

@p0mvn
Copy link
Member

p0mvn commented May 5, 2022

I see, thanks. I'm setting up a node right now to investigate on my side. Let me get back to you. If anyone finds a way to resolve this in the meantime, please let me know

@ChihuahuaChain
Copy link
Contributor

@p0mvn tried in [rpc] and [api] , but not works

Okay I fixed adding these lines exactly on the [grpc] section, it worked.

@p0mvn
Copy link
Member

p0mvn commented May 5, 2022

Right, thanks for the update @ChihuahuaChain

@liangping please try under [grpc]. If that fixes it for you, please close the issue

@ValarDragon
Copy link
Member

ValarDragon commented May 5, 2022

So whats happening if these configs aren't sent? Is the default assumed to be 0 at the moment, or something more reasonable?

Can we make a PR that makes an unset value the recommended default instead?

EDIT: This is fixed by Bez PR here: https://github.com/osmosis-labs/cosmos-sdk/pull/220/files

@p0mvn
Copy link
Member

p0mvn commented May 5, 2022

The default is set to the following:
https://github.com/osmosis-labs/cosmos-sdk/blob/18b0d2de413cdce6d3307588904dcdb2156f1eb9/server/config/config.go#L238-L239

That default is only used to create the config. If someone had an old config, 0 would be assumed, and yes Bez guarded against that case here: osmosis-labs/cosmos-sdk#220

@liangping
Copy link
Author

works now. @p0mvn

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development May 5, 2022
@liangping
Copy link
Author

Are folks having issues on all v7.x versions, or just v7.3.0?

On both 7.2.1 and 7.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants