Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Addresses in proto files from bytes to string #121

Closed
sunnya97 opened this issue Apr 30, 2021 · 0 comments · Fixed by #165
Closed

Switch Addresses in proto files from bytes to string #121

sunnya97 opened this issue Apr 30, 2021 · 0 comments · Fixed by #165
Assignees
Labels
proto-breaking Protobuf breaking changes: generally don't do this!

Comments

@sunnya97
Copy link
Collaborator

In some of the modules' proto files, addresses are defined by bytes to be gogoproto casted to sdk.AccAddress

Example:

message MsgCreatePot {
  bool is_perpetual = 1; // flag to show if it's perpetual or multi-epoch
                         // distribution incentives by third party
  bytes owner = 2 [ (gogoproto.casttype) =
                        "github.com/cosmos/cosmos-sdk/types.AccAddress" ];

...

These should be switched to strings as this is the standard in the cosmos sdk now.

@sunnya97 sunnya97 added the proto-breaking Protobuf breaking changes: generally don't do this! label Apr 30, 2021
@sunnya97 sunnya97 self-assigned this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proto-breaking Protobuf breaking changes: generally don't do this!
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant