From d76deee64911cdd21ae3914ef2912ff633bb960a Mon Sep 17 00:00:00 2001 From: Roman Date: Mon, 24 Oct 2022 18:20:10 -0400 Subject: [PATCH] link issues --- x/gamm/keeper/swap.go | 7 ++++--- x/swaprouter/router.go | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/x/gamm/keeper/swap.go b/x/gamm/keeper/swap.go index a33b1085a98..2c9f197162a 100644 --- a/x/gamm/keeper/swap.go +++ b/x/gamm/keeper/swap.go @@ -15,7 +15,8 @@ import ( // tokenOutMinAmount must be returned in the resulting asset returning an error // upon failure. Upon success, the resulting tokens swapped for are returned. A // swap fee is applied determined by the pool's parameters. -// TODO: decide the future of this method. Should we remove it? +// TODO: remove this method: +// https://github.com/osmosis-labs/osmosis/issues/3129 func (k Keeper) SwapExactAmountInDefaultSwapFee( ctx sdk.Context, sender sdk.AccAddress, @@ -37,8 +38,8 @@ func (k Keeper) SwapExactAmountInDefaultSwapFee( // as input to a pool, using the provided swapFee. This is intended to allow // different swap fees as determined by multi-hops, or when recovering from // chain liveness failures. -// TODO: investigate if we can only export this method for the swap-router module -// to mitigate the security risk from swapFee being taken in. +// TODO: investigate if swapFee can be unexported +// https://github.com/osmosis-labs/osmosis/issues/3130 func (k Keeper) SwapExactAmountIn( ctx sdk.Context, sender sdk.AccAddress, diff --git a/x/swaprouter/router.go b/x/swaprouter/router.go index 64fc02d3168..9e421063ea4 100644 --- a/x/swaprouter/router.go +++ b/x/swaprouter/router.go @@ -17,6 +17,7 @@ func (k Keeper) RouteExactAmountIn( tokenIn sdk.Coin, tokenOutMinAmount sdk.Int) (tokenOutAmount sdk.Int, err error) { // TODO: fix this once proper pool id routing exists + // https: //github.com/osmosis-labs/osmosis/issues/3097 isGamm := true swapModule := k.withSwapModule(isGamm) @@ -62,6 +63,7 @@ func (k Keeper) RouteExactAmountOut(ctx sdk.Context, tokenInMaxAmount sdk.Int, tokenOut sdk.Coin) (tokenInAmount sdk.Int, err error) { // TODO: fix this once proper pool id routing exists + // https://github.com/osmosis-labs/osmosis/issues/3097 isGamm := true swapModule := k.withSwapModule(isGamm)