Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement local staking proxy #34

Closed
maurolacy opened this issue May 25, 2023 · 2 comments
Closed

Implement local staking proxy #34

maurolacy opened this issue May 25, 2023 · 2 comments
Assignees
@maurolacy

Comments

@maurolacy
Copy link
Collaborator

maurolacy commented May 25, 2023 •
edited by ethanfrey
Loading

Complementary to the local staking contract.

  • Receive stake from the local staking module.
  • Unstake to the local staking module.

Also includes #8 for the full workflow of local proxy management
@maurolacy maurolacy self-assigned this May 25, 2023
@ethanfrey ethanfrey mentioned this issue Jun 1, 2023
Closed
@ethanfrey
Copy link
Collaborator

ethanfrey commented Jun 1, 2023 •
edited
Loading

I reviewed the state of the proxy and it looks pretty complete.

I guess this is about addressing TODO and FIXME and covering with some tests?

It would be cool to have real multi-tests with vault, native-staking, native-staking-proxy, as the other two are already tested independently.
Then, we see the whole flow of getting stake in, staking/voting, and getting stake out

@maurolacy maurolacy mentioned this issue Jun 3, 2023
Merged
10 tasks
@ethanfrey
Copy link
Collaborator

Closed by #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanfrey @maurolacy